airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs when serialization is enabled
Date Tue, 07 Jan 2020 13:42:09 GMT
ashb commented on a change in pull request #7092: [AIRFLOW-6347] BugFix: Can't get task logs
when serialization is enabled
URL: https://github.com/apache/airflow/pull/7092#discussion_r363752005
 
 

 ##########
 File path: airflow/serialization/serialized_objects.py
 ##########
 @@ -265,12 +266,9 @@ class SerializedBaseOperator(BaseOperator, BaseSerialization):
     Class specific attributes used by UI are move to object attributes.
     """
 
-    _decorated_fields = {'executor_config', }
+    _decorated_fields = {'executor_config', 'params'}
 
 Review comment:
   I think adding this change now changes the format of the serialization we store, and since
the previous format was in 1.10.7 I thin kthis means we now need to think about adding a v2
of the format and how we deal with upgrade etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message