airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] xinbinhuang commented on a change in pull request #6975: [AIRFLOW-1467] Dynamic pooling via allowing tasks to use more than one pool slot (depending upon the need)
Date Tue, 07 Jan 2020 08:08:48 GMT
xinbinhuang commented on a change in pull request #6975: [AIRFLOW-1467] Dynamic pooling via
allowing tasks to use more than one pool slot (depending upon the need)
URL: https://github.com/apache/airflow/pull/6975#discussion_r363630481
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -154,6 +154,7 @@ class TaskInstance(Base, LoggingMixin):
     unixname = Column(String(1000))
     job_id = Column(Integer)
     pool = Column(String(50), nullable=False)
+    pool_capacity = Column('pool_capacity', Integer, default=1)
 
 Review comment:
   Since the attribute name is the same as the `Column.name`, I suggest removing the `Column.name`
and use the default mapping to be consistent with the rest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message