airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] baolsen commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
Date Sat, 04 Jan 2020 05:52:14 GMT
baolsen commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r363018120
 
 

 ##########
 File path: setup.py
 ##########
 @@ -275,6 +275,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
 ]
 mssql = [
     'pymssql~=2.1.1',
+    'pyodbc',
 
 Review comment:
   I'm not sure why it would have an impact on the URI format.
   
   I was thinking it could be something like how config_kwargs and session_kwargs are used
in aws_hook:
   https://github.com/apache/airflow/blob/master/airflow/contrib/hooks/aws_hook.py
   
   ```
   # Dejson the 'extra' field first
   extra_config = connection_object.extra_dejson
   ...
   # Use nested extra = {'config_kwargs': { <dict of kwargs> }. <other stuff>
} to create AWS Config object
   config = Config(**extra_config["config_kwargs"])
   
   ```
   I took this approach because we needed to have config_kwargs and session_kwargs being stored
in the extra, along with a whole bunch of other existing settings that are kept there. 
   
   Let me know if this is roughly how you approached it. I'm surprised how it could be changing
the URI, because it should just be simply un-nesting and using the same values as it would
have without the nesting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message