airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
Date Wed, 01 Jan 2020 10:53:06 GMT
potiuk commented on issue #6987: [AIRFLOW-6416] Remove DB provide_session and sort by conn_id
URL: https://github.com/apache/airflow/pull/6987#issuecomment-570042926
 
 
   > And we could not remove @provide_session in function `merge_conn` due to some unittest
use it to create temp connections, do we? @potiuk
   
   The  @provide_session decorator (and merge_conn uses it) follow exactly the pattern of
optimisation - it's there to handle the case that a session is created once, transaction starts,
and you reuse the session do everything in the same transatction. So it is really needed :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message