From commits-return-82142-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Wed Dec 18 11:46:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6EAE5180660 for ; Wed, 18 Dec 2019 12:46:05 +0100 (CET) Received: (qmail 45316 invoked by uid 500); 18 Dec 2019 11:46:04 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 45306 invoked by uid 99); 18 Dec 2019 11:46:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Dec 2019 11:46:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1D48DC0D64 for ; Wed, 18 Dec 2019 11:46:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.989 X-Spam-Level: X-Spam-Status: No, score=-112.989 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_DMARC_STATUS=0.01, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id oRuZ8hHHafUe for ; Wed, 18 Dec 2019 11:46:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with SMTP id D4052BC862 for ; Wed, 18 Dec 2019 11:46:02 +0000 (UTC) Received: (qmail 45045 invoked by uid 99); 18 Dec 2019 11:46:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Dec 2019 11:46:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1A52AE30FE for ; Wed, 18 Dec 2019 11:46:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id DF514780923 for ; Wed, 18 Dec 2019 11:46:00 +0000 (UTC) Date: Wed, 18 Dec 2019 11:46:00 +0000 (UTC) From: "Ash Berlin-Taylor (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AIRFLOW-5487) airflow/utils/strings.py: Fix unused warning variable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-5487?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-5487: --------------------------------------- Fix Version/s: (was: 1.10.6) 1.10.7 > airflow/utils/strings.py: Fix unused warning variable > ----------------------------------------------------- > > Key: AIRFLOW-5487 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5487 > Project: Apache Airflow > Issue Type: Bug > Components: utils > Affects Versions: 1.10.6 > Reporter: Jakob Homan > Priority: Minor > Labels: ccoss2019, newbie > Fix For: 1.10.7 > > > Note: This ticket's being created to facilitate a new contributor's works= hop for Airflow. After the workshop has completed, I'll mark these all avai= lable for anyone that might like to take them on. > airflow/utils/strings.py:27 > {code:java} > def get_random_string(length=3D8, choices=3Dstring.ascii_letters + string= .digits): > ''' > Generate random string > ''' > return ''.join([choice(choices) for i in range(length)]) {code} > Here we use an `i` for a placeholder variable, but this gets flagge as an= unused variable.=C2=A0 We can replace the `i` with `_` and avoid this warn= ing. -- This message was sent by Atlassian Jira (v8.3.4#803005)