From commits-return-81580-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Tue Dec 17 03:45:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 55657180660 for ; Tue, 17 Dec 2019 04:45:06 +0100 (CET) Received: (qmail 24988 invoked by uid 500); 17 Dec 2019 03:45:05 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 24967 invoked by uid 99); 17 Dec 2019 03:45:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2019 03:45:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1DD1B1A186D for ; Tue, 17 Dec 2019 03:45:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.99 X-Spam-Level: X-Spam-Status: No, score=-112.99 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_DMARC_STATUS=0.01, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qxzORdQ5RffI for ; Tue, 17 Dec 2019 03:45:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with SMTP id C25DABC555 for ; Tue, 17 Dec 2019 03:45:01 +0000 (UTC) Received: (qmail 24762 invoked by uid 99); 17 Dec 2019 03:45:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2019 03:45:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D151DE3118 for ; Tue, 17 Dec 2019 03:45:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 50678780477 for ; Tue, 17 Dec 2019 03:45:00 +0000 (UTC) Date: Tue, 17 Dec 2019 03:45:00 +0000 (UTC) From: "ASF subversion and git services (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (AIRFLOW-5463) Variable set is not atomic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997856#comment-16997856 ] ASF subversion and git services commented on AIRFLOW-5463: ---------------------------------------------------------- Commit 7f76f56adccdf9b8fd7a3b8f0e8cdc1dc109a9ba in airflow's branch refs/heads/v1-10-test from Robert Young [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7f76f56 ] [AIRFLOW-5463] Use same session to delete and add variable in set (#6807) Why: * In our system we had a postgres connection error during Variable.set resulting in the variable being deleted. The intention of this change is that an error should leave the variable unchanged. (cherry picked from commit 5483ae4992f888ac467a9cf4977a01331fb10160) > Variable set is not atomic > -------------------------- > > Key: AIRFLOW-5463 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5463 > Project: Apache Airflow > Issue Type: Bug > Components: core, models > Affects Versions: 1.10.5 > Reporter: Cedrik Neumann > Priority: Major > Fix For: 1.10.7 > > > The function \{{Variable.set}} deletes the variable first > [https://github.com/apache/airflow/blob/1.10.5/airflow/models/variable.py#L137] > although it doesn't pass the DB session as an argument, thus delete and add don't run in an atomic operation. -- This message was sent by Atlassian Jira (v8.3.4#803005)