From commits-return-84619-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Sun Dec 29 23:52:34 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 307E418063F for ; Mon, 30 Dec 2019 00:52:34 +0100 (CET) Received: (qmail 6870 invoked by uid 500); 29 Dec 2019 23:52:33 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 6860 invoked by uid 99); 29 Dec 2019 23:52:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Dec 2019 23:52:33 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] mik-laj commented on a change in pull request #6957: [AIRFLOW-6396] Use tempfile.TemporaryDirectory instead of custom one Message-ID: <157766355323.29412.11922076746188067094.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 29 Dec 2019 23:52:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mik-laj commented on a change in pull request #6957: [AIRFLOW-6396] Use tempfile.TemporaryDirectory instead of custom one URL: https://github.com/apache/airflow/pull/6957#discussion_r361879711 ########## File path: UPDATING.md ########## @@ -41,6 +41,10 @@ assists users migrating to a new version. ## Airflow Master +### Remove airflow.utils.file.TemporaryDirectory + +Removing this because the same functionality is provided by `tempfile.TemporaryDirectory`. Review comment: No. This is based on my experience. I would expect the following points, so I try to include them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services