From commits-return-80759-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Thu Dec 12 11:54:44 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A4F5918061A for ; Thu, 12 Dec 2019 12:54:43 +0100 (CET) Received: (qmail 44171 invoked by uid 500); 12 Dec 2019 11:54:43 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 44162 invoked by uid 99); 12 Dec 2019 11:54:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Dec 2019 11:54:42 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] ashb commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL query building for hot-path queries Message-ID: <157615168287.23760.597332449189997279.gitbox@gitbox.apache.org> Date: Thu, 12 Dec 2019 11:54:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL query building for hot-path queries URL: https://github.com/apache/airflow/pull/6792#discussion_r357104629 ########## File path: airflow/jobs/scheduler_job.py ########## @@ -1006,8 +978,7 @@ def _change_state_for_tis_without_dagrun(self, ) Stats.gauge('scheduler.tasks.without_dagrun', tis_changed) - @provide_session - def __get_concurrency_maps(self, states, session=None): + def __get_concurrency_maps(self, states, session): Review comment: Because I _want_ to force a session to be reused. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services