From commits-return-80384-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Tue Dec 10 21:41:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8AB6B180630 for ; Tue, 10 Dec 2019 22:41:12 +0100 (CET) Received: (qmail 55226 invoked by uid 500); 10 Dec 2019 21:41:11 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 55217 invoked by uid 99); 10 Dec 2019 21:41:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Dec 2019 21:41:11 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] ashb commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible Message-ID: <157601407179.3571.11686418823180989612.gitbox@gitbox.apache.org> Date: Tue, 10 Dec 2019 21:41:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible URL: https://github.com/apache/airflow/pull/2460#discussion_r356292532 ########## File path: airflow/jobs.py ########## @@ -892,6 +891,11 @@ def create_dag_run(self, dag, session=None): if next_run_date and min_task_end_date and next_run_date > min_task_end_date: return + # Don't really schedule the job, we are interested in its next run date + # as calculated by the scheduler + if dry_run is True: + return next_run_date Review comment: @ultrabug _This_ was my complaint - I don't think we should be calling this method to work out when the next exec date is -- cos this can return None when the dag concurrecy is at it's limit for instance (line 789) and that is the problem. I think it's going to cause confusion that the "scheduled in" column would come-and-go depending on what other runs might be happening. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services