From commits-return-78826-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Dec 2 09:43:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C15F318064E for ; Mon, 2 Dec 2019 10:43:03 +0100 (CET) Received: (qmail 17536 invoked by uid 500); 2 Dec 2019 09:43:03 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 17526 invoked by uid 99); 2 Dec 2019 09:43:03 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Dec 2019 09:43:03 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports Message-ID: <157527978294.12375.14482369727200484481.gitbox@gitbox.apache.org> Date: Mon, 02 Dec 2019 09:43:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#discussion_r352497006 ########## File path: airflow/__init__.py ########## @@ -44,23 +44,8 @@ settings.initialize() -login = None # type: Optional[Callable] +from airflow.plugins_manager import integrate_plugins Review comment: Oh, cos importing plugins mananger needs settings to have been loaded. Right. _somewhat_ off scope, so this can probably stay as it is for now, but we could move all of the top level code in airflow.plugins_manager in to this new `integrate_plugins` method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services