From commits-return-78743-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Sun Dec 1 16:29:07 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BD7AF18061A for ; Sun, 1 Dec 2019 17:29:06 +0100 (CET) Received: (qmail 38848 invoked by uid 500); 1 Dec 2019 16:29:06 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 38838 invoked by uid 99); 1 Dec 2019 16:29:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Dec 2019 16:29:06 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] codecov-io edited a comment on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports Message-ID: <157521774599.10289.1892336266451754451.gitbox@gitbox.apache.org> Date: Sun, 01 Dec 2019 16:29:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io edited a comment on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports URL: https://github.com/apache/airflow/pull/6596#issuecomment-559224555 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6596?src=pr&el=h1) Report > Merging [#6596](https://codecov.io/gh/apache/airflow/pull/6596?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/2f2f89c148e2b694aee9402707f68065ee7320f8?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `83.33%`. [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6596/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6596?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #6596 +/- ## ========================================== - Coverage 83.84% 83.83% -0.01% ========================================== Files 668 669 +1 Lines 37555 37682 +127 ========================================== + Hits 31487 31592 +105 - Misses 6068 6090 +22 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6596?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `85.71% <ø> (ø)` | :arrow_up: | | [airflow/logging\_config.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9sb2dnaW5nX2NvbmZpZy5weQ==) | `97.5% <ø> (ø)` | :arrow_up: | | [airflow/macros/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvX19pbml0X18ucHk=) | `81.25% <ø> (-5.12%)` | :arrow_down: | | [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `6.25% <10.71%> (+0.25%)` | :arrow_up: | | [airflow/jobs/base\_job.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2Jhc2Vfam9iLnB5) | `88.81% <100%> (+0.07%)` | :arrow_up: | | [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `88.81% <100%> (ø)` | :arrow_up: | | [airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5) | `86.58% <100%> (+0.1%)` | :arrow_up: | | [airflow/models/kubernetes.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMva3ViZXJuZXRlcy5weQ==) | `100% <100%> (ø)` | :arrow_up: | | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.48% <100%> (+0.05%)` | :arrow_up: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `91.97% <100%> (ø)` | :arrow_up: | | ... and [24 more](https://codecov.io/gh/apache/airflow/pull/6596/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6596?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6596?src=pr&el=footer). Last update [2f2f89c...6d89b46](https://codecov.io/gh/apache/airflow/pull/6596?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services