airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6238) Dags stats endpoint is slow and returns a large payload
Date Thu, 12 Dec 2019 15:51:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994800#comment-16994800
] 

ASF GitHub Bot commented on AIRFLOW-6238:
-----------------------------------------

robinedwards commented on pull request #6803: [AIRFLOW-6238] Filter dags returned by dag_stats
URL: https://github.com/apache/airflow/pull/6803
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title.
     - https://issues.apache.org/jira/browse/AIRFLOW-6238
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The dag_stats endpoint returns all dags by default. This can result in an extremely large
payload ~ 3mb and slow response time when you have a lot of dags (In our case 1500+).
   
   The accompanying pull request adds a dag_ids get parameter to the dag_stats end point which
is populated by the dags present on the page.
   
   Please see related and merged issue for task_stats: https://issues.apache.org/jira/browse/AIRFLOW-6095
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
    NA.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Dags stats endpoint is slow and returns a large payload
> -------------------------------------------------------
>
>                 Key: AIRFLOW-6238
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6238
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: api, ui
>    Affects Versions: 2.0.0, 1.10.6
>            Reporter: Robin Edwards
>            Priority: Minor
>
> The dag_stats endpoint returns all dags by default. This can result in an extremely large
payload ~ 3mb and slow response time when you have a lot of dags (In our case 1500+).
> The accompanying pull request adds a dag_ids get parameter to the dag_stats end point
which is populated by the dags present on the page.
> Please see previous issue for task_stats AIRFLOW-6095 which has already been merged with
a similar solution



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message