airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6185) SQLAlchemy Connection model schema not aligned with Alembic schema
Date Wed, 18 Dec 2019 20:34:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999487#comment-16999487
] 

ASF subversion and git services commented on AIRFLOW-6185:
----------------------------------------------------------

Commit 541edc7b27d6d002c63b9ae93c6d1b5892d59aea in airflow's branch refs/heads/v1-10-test
from Xinbin Huang
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=541edc7 ]

[AIRFLOW-6185] SQLAlchemy Connection model schema not aligned with Alembic schema (#6754)

* [AIRFLOW-6185] SQLAlchemy Connection model schema aligned with Alembic schema

(cherry picked from commit e04059d88387117d85423dbfb258bbaa90220dcb)


> SQLAlchemy Connection model schema not aligned with Alembic schema
> ------------------------------------------------------------------
>
>                 Key: AIRFLOW-6185
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6185
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: database
>    Affects Versions: 1.10.6
>            Reporter: Xinbin Huang
>            Priority: Minor
>             Fix For: 1.10.7
>
>         Attachments: connection_schema.PNG
>
>
> The SQLAlchemy model for the `Connection` table declare password as `String(5000)` while
Alembic migration script (i.e. `current_schema.py`) declare password as `String(length=500)`,
and the final table schema for password is varchar(500)
>  * Alembic schema: [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/migrations/versions/e3a246e0dc1_current_schema.py#L54]
>  * models/connections.py
>  [https://github.com/apache/airflow/blob/ce873afc22efee171a320344b5cbee657018aed0/airflow/models/connection.py#L62]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message