airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6165) Housekeeping for utils.dates.date_range(), and add tests for it
Date Tue, 03 Dec 2019 15:57:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987026#comment-16987026
] 

ASF GitHub Bot commented on AIRFLOW-6165:
-----------------------------------------

XD-DENG commented on pull request #6720: [AIRFLOW-6165] Housekeep utils.dates.date_range &
add tests
URL: https://github.com/apache/airflow/pull/6720
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6165
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow
Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd
Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   `utils.dates.date_range` has a few issues, like missing docstring, doesn't handle wrong-type
input properly, and always try to run `timezone.make_naive` on `start_date` even if it's already
naive (which will cause exception).
   
   This PR addresses these issues, and add tests for `utils.dates.date_range`.
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Housekeeping for utils.dates.date_range(), and add tests for it
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-6165
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6165
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: utils
>    Affects Versions: 1.10.6
>            Reporter: Xiaodong Deng
>            Assignee: Xiaodong Deng
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> There are some issues in *utils.dates.date_range()*, like missing docstring, missing
proper handle on wrong input, etc. And it doesn't come with enough test coverage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message