airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6142) Different results for pylint locally and in Travis CI
Date Mon, 02 Dec 2019 18:38:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986256#comment-16986256
] 

ASF subversion and git services commented on AIRFLOW-6142:
----------------------------------------------------------

Commit 91eb87112b343ce4c18a994a41703bf793125dca in airflow's branch refs/heads/master from
Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=91eb871 ]

[AIRFLOW-6142] Fix different local/Travis pylint results (#6705)

* [AIRFLOW-6142] Fix different local/Travis pylint results

Sometimes Pylint on Travis CI gives still different results than the one run
locally. This was happening because we were using the
AIRFLOW_MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS="true" for static checks. This is
needed for checklicence check only - just to make sure that all source files
(including scripts etc.) are mounted to the container.

However this makes it slightly different when it comes to pylint checks. We
would like to have it exactly identical when run locally and in CI so in case
of static checks we should rather use
AIRFLOW_MOUNT_HOST_VOLUMES_FOR_STATIC_CHECKS="true" for all checks but the
Checklicence one - same as used locally.

This way running:

pre-commit run pylint --all-files

Should always give the same results locally and in Travis.

* Update scripts/ci/_utils.sh

Co-Authored-By: Felix Uellendall <feluelle@users.noreply.github.com>


> Different results for pylint locally and in Travis CI
> -----------------------------------------------------
>
>                 Key: AIRFLOW-6142
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6142
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: ci
>    Affects Versions: 2.0.0
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>             Fix For: 2.0.0
>
>
> Sometimes Pylint on Travis CI gives still different results than the one run locally.
This seems to be happening because we are using the AIRFLOW_MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS="true"
for static checks. This is needed for checklicence check only - just to make sure that all
source files (including scripts etc.) are mounted to the container. However this makes it
slightly different when it comes to pylint checks. We would like to have it exactly identical
when run locally and in CI so in case of static checks we should rather use AIRFLOW_MOUNT_HOST_VOLUMES_FOR_STATIC_CHECKS="true"
for all checks but the Checklicence one . - same as used locally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message