airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-6142) Different results for pylint locally and in Travis CI
Date Sun, 01 Dec 2019 19:57:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985662#comment-16985662
] 

ASF GitHub Bot commented on AIRFLOW-6142:
-----------------------------------------

potiuk commented on pull request #6705: [AIRFLOW-6142] Fix different local/Travis pylint results
URL: https://github.com/apache/airflow/pull/6705
 
 
   Sometimes Pylint on Travis CI gives still different results than the one run
   locally. This was happening because we were using the
   AIRFLOW_MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS="true" for static checks. This is
   needed for checklicence check only - just to make sure that all source files
   (including scripts etc.) are mounted to the container.
   
   However this makes it slightly different when it comes to pylint checks. We
   would like to have it exactly identical when run locally and in CI so in case
   of static checks we should rather use
   AIRFLOW_MOUNT_HOST_VOLUMES_FOR_STATIC_CHECKS="true" for all checks but the
   Checklicence one - same as used locally.
   
   This way running:
   
   pre-commit run pylint --all-files
   
   Should always give the same results locally and in Travis.
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6142
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Different results for pylint locally and in Travis CI
> -----------------------------------------------------
>
>                 Key: AIRFLOW-6142
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6142
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: ci
>    Affects Versions: 2.0.0
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> Sometimes Pylint on Travis CI gives still different results than the one run locally.
This seems to be happening because we are using the AIRFLOW_MOUNT_SOURCE_DIR_FOR_STATIC_CHECKS="true"
for static checks. This is needed for checklicence check only - just to make sure that all
source files (including scripts etc.) are mounted to the container. However this makes it
slightly different when it comes to pylint checks. We would like to have it exactly identical
when run locally and in CI so in case of static checks we should rather use AIRFLOW_MOUNT_HOST_VOLUMES_FOR_STATIC_CHECKS="true"
for all checks but the Checklicence one . - same as used locally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message