airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Potiuk (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (AIRFLOW-5490) security.py: replace == None with is_() comparison
Date Fri, 20 Dec 2019 16:04:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000986#comment-17000986
] 

Jarek Potiuk edited comment on AIRFLOW-5490 at 12/20/19 4:03 PM:
-----------------------------------------------------------------

Look at the history - it's been marked as "Fixed" and "Closed" by [~kaxilnaik] initially (after
it was implemented and reverted).  Since it was closed already I figured we do not want to
fix it any more. It was one of the tickets that had no fixVersion set so I reopened it/resolved
and set resolution to "won't fix" resolution (which I think is better than "closed" without
explanation). In my scripts the "won't fix" resolutionn is the only "closed" state that can
have no fixVersion (because we won't fix it). 

Do you think we want to do something with this ticket.


was (Author: potiuk):
Looke at the history - it's been marked as "Fixed" and "Closed" by [~kaxilnaik] initially
(after it was implemented and reverted).  Since it was closed already I figured we do not
want to fix it any more. It was one of the tickets that had no fixVersion set so I reopened
it/resolved and set resolution to "won't fix" resolution (which I think is better than "closed"
without explanation). In my scripts the "won't fix" resolutionn is the only "closed" state
that can have no fixVersion (because we won't fix it). 

Do you think we want to do something with this ticket.

> security.py: replace == None with is_() comparison
> --------------------------------------------------
>
>                 Key: AIRFLOW-5490
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5490
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: webserver
>    Affects Versions: 1.10.6
>            Reporter: Jakob Homan
>            Priority: Minor
>              Labels: ccoss2019, newbie
>
> Note: This ticket's being created to facilitate a new contributor's workshop for Airflow.
After the workshop has completed, I'll mark these all available for anyone that might like
to take them on.
> In security.py, we twice use {{col == None}}, which is confusing (it works, as SQLAlchemy
handles this) but using {{is_(None)}} avoids this confusion.
> airflow/www/security.py:343
> {code:python}
> sqla_models.PermissionView.permission == None,  # noqa pylint: disable=singleton-comparison
>     sqla_models.PermissionView.view_menu == None,  # noqa pylint: disable=singleton-comparison
> )) {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message