airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5463) Variable set is not atomic
Date Tue, 17 Dec 2019 03:45:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997856#comment-16997856
] 

ASF subversion and git services commented on AIRFLOW-5463:
----------------------------------------------------------

Commit 7f76f56adccdf9b8fd7a3b8f0e8cdc1dc109a9ba in airflow's branch refs/heads/v1-10-test
from Robert Young
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7f76f56 ]

[AIRFLOW-5463] Use same session to delete and add variable in set (#6807)

Why:
* In our system we had a postgres connection error during Variable.set
resulting in the variable being deleted. The intention of this change is
that an error should leave the variable unchanged.

(cherry picked from commit 5483ae4992f888ac467a9cf4977a01331fb10160)


> Variable set is not atomic
> --------------------------
>
>                 Key: AIRFLOW-5463
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5463
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: core, models
>    Affects Versions: 1.10.5
>            Reporter: Cedrik Neumann
>            Priority: Major
>             Fix For: 1.10.7
>
>
> The function \{{Variable.set}} deletes the variable first
> [https://github.com/apache/airflow/blob/1.10.5/airflow/models/variable.py#L137]
> although it doesn't pass the DB session as an argument, thus delete and add don't run
in an atomic operation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message