airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6933: [AIRFLOW-6376] Extract order_queued_tasks_by_priority method
Date Sat, 28 Dec 2019 00:32:42 GMT
mik-laj commented on a change in pull request #6933: [AIRFLOW-6376] Extract order_queued_tasks_by_priority
method
URL: https://github.com/apache/airflow/pull/6933#discussion_r361765886
 
 

 ##########
 File path: airflow/executors/base_executor.py
 ##########
 @@ -150,16 +150,25 @@ def heartbeat(self) -> None:
         self.log.debug("Calling the %s sync method", self.__class__)
         self.sync()
 
-    def trigger_tasks(self, open_slots: int) -> None:
+    def order_queued_tasks_by_priority(self) -> List[Tuple[TaskInstanceKeyType, QueuedTaskInstanceType]]:
 
 Review comment:
   This could make it harder to understand the code.  Note that a loop is used below that
iterates over the result of this function, but at the same time modifies self.queued_tasks).
If we create a property here, it will be difficult to see that property and self.queued_task
are related.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message