airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on issue #6876: [AIRFLOW-6322] Add pytest.mark.slow marker
Date Wed, 25 Dec 2019 14:12:17 GMT
potiuk commented on issue #6876: [AIRFLOW-6322] Add pytest.mark.slow marker
URL: https://github.com/apache/airflow/pull/6876#issuecomment-568903744
 
 
   Hey @dazza-codes @nuclearpinguin  -> just to be clear - I am not agains slow/fast/ etc.
markers. quite the opposite - I think they might make quite some sense.  I am just not sure
if we know what we name 'slow' and what is 'not slow' - so it would be great to discuss it
and agree before we introduce such marker. Maybe we want to make "very-slow". "slow", "slowish"
or something :). 
   
   I saw projects using different strategies and naming (for example t-shirt sizes S, M, L,
XL, XXL) or "big", "medium", "small". 
   
   What I am here for is to clearly define what such markers are and what exactly we want
to achieve by having them rather than introduce them first and think about how to use them
later. For me introducing a term without explaining what's the context, how we are going to
use it and what we want to achieve is adding noise rather than solving problem.
   
   For example I'd say we want to have a goal "all fast tests together  should run under 2
minutes" (this is just an example) or "we want to have all the tests marked as slow if they
run > 2 seconds".  And the timing summary presented by pytest might be useful to make some
predictions and intelligent guesses for those values.
   
   @dazza-codes : Just as example you can take a look at the proposal I made in the discussion
at the devlist where I explained not only what markers i propose, but also how they fit in
the current development environment we have, how I think we use the markers and what I want
to achieve by adding those markers.  
   
   https://lists.apache.org/thread.html/4538437c96f599766005ba7829d0bee1511debb4f53599e0d300a56f%40%3Cdev.airflow.apache.org%3E
   
   Since we are an Apache Project all such discussions should happen in the devlist when they
are affecting all community - so I encourage you to add proposal, context and explanation
there - so that others can at least have a chance to see it and comment. I think discussing
it in PR is not enough - as it affects all contributors. We are talking about something potentially
everyone will use.
   
   Feel free to continue it in this discussion or start your own thread! Even if you have
no concrete vision yet, you can start discussing it there and maybe others will have and join
your discussion.
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message