airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] yuqian90 commented on issue #6422: [AIRFLOW-5690] Change log level local_task_job.py
Date Wed, 18 Dec 2019 05:02:05 GMT
yuqian90 commented on issue #6422: [AIRFLOW-5690] Change log level local_task_job.py
URL: https://github.com/apache/airflow/pull/6422#issuecomment-566868488
 
 
   > @adityav It is actually a bit more than that. What it implies is that the heart beating
is being throttled because of the high heart rate.
   
   I'm trying to read the code to understand how to silence this line. This line is called
in the loop whenever `time_since_last_heartbeat` is smaller than `self.heartrate`. But since
the code only sleeps for `self.heartrate - time_since_last_heartbeat`, and then the loop goes
to the next iteration. So if the worker is fast enough, there's bound to be a small variation
when `time_since_last_heartbeat` is computed again. It is most likely going to be smaller
than `self.heartrate`. So this line keeps spamming. There seems to be no way to stop this.
And this line is also not useful because it basically says the task is still heartbeating.

   
   ```
                       self.log.warning("Time since last heartbeat(%.2f s) < heartrate(%s
s)"
                                        ", sleeping for %s s", time_since_last_heartbeat,
                                        self.heartrate, sleep_for)
   ```
   
   How about changing it to self.log.trace() or remove it completely?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message