airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL query building for hot-path queries
Date Thu, 12 Dec 2019 12:49:46 GMT
mik-laj commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL query building
for hot-path queries
URL: https://github.com/apache/airflow/pull/6792#discussion_r357126625
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -1318,6 +1284,7 @@ def _enqueue_task_instances_with_queued_state(self, simple_dag_bag,
                 command,
                 priority=priority,
                 queue=queue)
+        return i+1
 
 Review comment:
   In the previous version, we use len() on list. It doesn't look like it needs optimization.
   https://github.com/apache/airflow/pull/6792/files/59fbc2f84a96c1677c8e420d7ce761f1d82b06ac#diff-c35269bcfbbe386e269ffa7487e86192L1355

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message