airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL query building for hot-path queries
Date Thu, 12 Dec 2019 07:46:43 GMT
mik-laj commented on a change in pull request #6792: [AIRFLOW-5930] Use cached-SQL query building
for hot-path queries
URL: https://github.com/apache/airflow/pull/6792#discussion_r356997115
 
 

 ##########
 File path: airflow/models/dagrun.py
 ##########
 @@ -286,25 +321,27 @@ def update_state(self, session=None):
             session=session
 
 Review comment:
   Can you check if double calling get_task_instances is faster than filtering the list in
Python? Line 319 and 306 contains calls to the get_task_instances method, and this method
invokes a database query.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message