airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] mik-laj commented on a change in pull request #6776: [AIRFLOW-6220] BigQuery - remove redundant hook tests after renaming
Date Wed, 11 Dec 2019 14:30:43 GMT
mik-laj commented on a change in pull request #6776: [AIRFLOW-6220] BigQuery - remove redundant
hook tests after renaming
URL: https://github.com/apache/airflow/pull/6776#discussion_r356630242
 
 

 ##########
 File path: tests/gcp/hooks/test_bigquery_system.py
 ##########
 @@ -32,7 +32,7 @@ def setUp(self):
         self.instance = hook.BigQueryHook()
 
     @mock.patch(
 
 Review comment:
   Why do we do mocking in system tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message