airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible
Date Tue, 10 Dec 2019 21:41:11 GMT
ashb commented on a change in pull request #2460: [AIRFLOW-1424] make the next execution date
of DAGs visible
URL: https://github.com/apache/airflow/pull/2460#discussion_r356292532
 
 

 ##########
 File path: airflow/jobs.py
 ##########
 @@ -892,6 +891,11 @@ def create_dag_run(self, dag, session=None):
             if next_run_date and min_task_end_date and next_run_date > min_task_end_date:
                 return
 
+            # Don't really schedule the job, we are interested in its next run date
+            # as calculated by the scheduler
+            if dry_run is True:
+                return next_run_date
 
 Review comment:
   @ultrabug _This_ was my complaint - I don't think we should be calling this method to work
out when the next exec date is -- cos this can return None when the dag concurrecy is at it's
limit for instance (line 789) and that is the problem. I think it's going to cause confusion
that the "scheduled in" column would come-and-go depending on what other runs might be happening.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message