airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file
Date Tue, 10 Dec 2019 12:07:41 GMT
ashb commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be
configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r356000124
 
 

 ##########
 File path: airflow/kubernetes/worker_configuration.py
 ##########
 @@ -362,24 +366,17 @@ def generate_dag_volume_mount_path(self) -> str:
 
         return self.kube_config.git_dags_folder_mount_point
 
-    def make_pod(self, namespace, worker_uuid, pod_id, dag_id, task_id, execution_date,
 
 Review comment:
   Why are these removed, and where are they now set on the pod?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message