airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be configured from JSON/YAML file
Date Tue, 10 Dec 2019 11:41:59 GMT
ashb commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S worker pod to be
configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r355989741
 
 

 ##########
 File path: airflow/kubernetes/pod_generator.py
 ##########
 @@ -60,74 +71,118 @@ class PodGenerator:
     Contains Kubernetes Airflow Worker configuration logic
 
     Represents a kubernetes pod and manages execution of a single pod.
+    Any configuration that is container specific gets applied to
+    the first container in the list of containers.
+
+    Parameters with a type of `kubernetes.client.models.*`/`k8s.*` can
+    often be replaced with their dictionary equivalent, e.i. the output of
+    `sanitize_for_serialization`.
 
 Review comment:
   ```suggestion
       ``sanitize_for_serialization``.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message