airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] nuclearpinguin commented on a change in pull request #6740: [AIRFLOW-6181] Add InProcessExecutor
Date Fri, 06 Dec 2019 12:07:28 GMT
nuclearpinguin commented on a change in pull request #6740: [AIRFLOW-6181] Add InProcessExecutor
URL: https://github.com/apache/airflow/pull/6740#discussion_r354802412
 
 

 ##########
 File path: airflow/executors/executor_loader.py
 ##########
 @@ -51,7 +52,7 @@ def get_default_executor(cls) -> BaseExecutor:
         return cls._default_executor
 
     @staticmethod
-    def _get_executor(executor_name: str) -> BaseExecutor:
+    def _get_executor(executor_name: str) -> BaseExecutor:  # pylint: disable=too-many-return-statements
 
 Review comment:
   @feluelle you are right that it can be simplified but still there will be a lot of return
statements. I will fix it in other way 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message