airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] kaxil commented on a change in pull request #6715: [AIRFLOW-5945] Make inbuilt OperatorLinks work when using Serialization
Date Tue, 03 Dec 2019 11:00:34 GMT
kaxil commented on a change in pull request #6715: [AIRFLOW-5945] Make inbuilt OperatorLinks
work when using Serialization
URL: https://github.com/apache/airflow/pull/6715#discussion_r353112710
 
 

 ##########
 File path: airflow/contrib/operators/qubole_operator.py
 ##########
 @@ -240,3 +241,9 @@ def __setattr__(self, name, value):
             self.kwargs[name] = value
         else:
             object.__setattr__(self, name, value)
+
+    @classmethod
+    def get_serialized_fields(cls):
+        """Serialized QuboleOperator contain exactly these fields."""
+        cls._serialized_fields = frozenset(super().get_serialized_fields() | {"qubole_conn_id"})
 
 Review comment:
   The only reason I stored it is for consistency as otherwise `cls._serialized_fields` will
have a different value than `cls.get_serialized_fields()`. We don't use `cls._serialized_fields`
anywhere, maybe we can just remove it from the Base Class too than WDYT? If not, let's keep
it at both places as the results won't match

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message