airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers
Date Mon, 02 Dec 2019 17:22:15 GMT
aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs
process with workers
URL: https://github.com/apache/airflow/pull/6709#discussion_r352720846
 
 

 ##########
 File path: airflow/cli/commands/worker_command.py
 ##########
 @@ -76,17 +85,19 @@ def worker(args):
             stderr=stderr,
         )
         with ctx:
-            sub_proc = subprocess.Popen(['airflow', 'serve_logs'], env=env, close_fds=True)
+            if skip_serve_logs is False:
+                sub_proc = subprocess.Popen(['airflow', 'serve_logs'], env=env, close_fds=True)
             worker.run(**options)
-            sub_proc.kill()
 
 Review comment:
   Don't you need to keep this line and have an "if skip_serve_logs is False:" line above
it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message