airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports
Date Mon, 02 Dec 2019 12:14:12 GMT
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r352563506
 
 

 ##########
 File path: airflow/executors/local_executor.py
 ##########
 @@ -43,40 +42,44 @@
 This option could lead to the unification of the executor implementations, running
 locally, into just one `LocalExecutor` with multiple modes.
 """
-
-import multiprocessing
 import subprocess
-from queue import Empty
-
-from airflow.executors.base_executor import BaseExecutor
+from multiprocessing import Manager, Process
+from multiprocessing.managers import SyncManager
+from queue import Empty, Queue  # pylint: disable=unused-import  # noqa: F401
+from typing import Any, List, Optional, Tuple, Union  # pylint: disable=unused-import # noqa:
F401
+
+from airflow import AirflowException
 
 Review comment:
   Did we not say that inside the core this should be imported from `airflow.exceptions` directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message