airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports
Date Mon, 02 Dec 2019 09:43:02 GMT
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r352497006
 
 

 ##########
 File path: airflow/__init__.py
 ##########
 @@ -44,23 +44,8 @@
 
 settings.initialize()
 
-login = None  # type: Optional[Callable]
+from airflow.plugins_manager import integrate_plugins
 
 Review comment:
   Oh, cos importing plugins mananger needs settings to have been loaded. Right.
   
   _somewhat_ off scope, so this can probably stay as it is for now, but we could move all
of the top level code in airflow.plugins_manager in to this new `integrate_plugins` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message