From commits-return-77708-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Tue Nov 26 23:16:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1AB2E18065D for ; Wed, 27 Nov 2019 00:16:05 +0100 (CET) Received: (qmail 15397 invoked by uid 500); 26 Nov 2019 23:16:04 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 15388 invoked by uid 99); 26 Nov 2019 23:16:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Nov 2019 23:16:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B721D1A0183 for ; Tue, 26 Nov 2019 23:16:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.19 X-Spam-Level: X-Spam-Status: No, score=-112.19 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_DMARC_STATUS=0.01, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nJFLNGKU6NL0 for ; Tue, 26 Nov 2019 23:16:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with SMTP id E62B07DC1E for ; Tue, 26 Nov 2019 23:16:01 +0000 (UTC) Received: (qmail 15174 invoked by uid 99); 26 Nov 2019 23:16:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Nov 2019 23:16:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B4489E29D3 for ; Tue, 26 Nov 2019 23:16:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 259AE78077D for ; Tue, 26 Nov 2019 23:16:00 +0000 (UTC) Date: Tue, 26 Nov 2019 23:16:00 +0000 (UTC) From: "Kamil Bregula (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (AIRFLOW-6070) On the admin dashboard, the recent tasks column has no tooltip for tasks in 'null' state MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AIRFLOW-6070?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula resolved AIRFLOW-6070. ------------------------------------ Resolution: Duplicate This has already been fixed in Airflow. Please note=C2=A0that this is not a= ticket system for Cloud Composer. If you have bugs that are in Cloud Compo= ser then you should report them to Google or test if the problem occurs in = other versions of Airflow. > On the admin dashboard, the recent tasks column has no tooltip for tasks = in 'null' state > -------------------------------------------------------------------------= --------------- > > Key: AIRFLOW-6070 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6070 > Project: Apache Airflow > Issue Type: Bug > Components: ui > Affects Versions: 1.10.2 > Environment: GCP Composer composer-1.7.5-airflow-1.10.2 > Reporter: Adam Hopkinson > Priority: Trivial > Attachments: image-2019-11-26-10-03-40-377.png > > > On the DAGS listing template, the circles in the=C2=A0_Recent Tasks_ colu= mn all have a tooltip apart from the second to last - which is for tasks wi= th state =3D `null` > !image-2019-11-26-10-03-40-377.png|width=3D261,height=3D37! > I believe this is happening in [this line of code|https://github.com/apac= he/airflow/blob/0ff9e2307042ba95e69b32e37f2fc767a5fdc36d/airflow/www/templa= tes/airflow/dags.html#L447], which is: > {{.attr('title', function(d) \{return d.state || 'none'})}} > I'm not sure why it's not falling back to 'none' - I think it's possibly = seeing the value of d.state as the text value 'null' rather than a true nul= l, but then putting that into the title as true null. > I'm using GCP Composer, so don't have a local instance of Airflow that I = can test. -- This message was sent by Atlassian Jira (v8.3.4#803005)