From commits-return-74429-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Fri Nov 8 11:36:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 18FB2180638 for ; Fri, 8 Nov 2019 12:36:04 +0100 (CET) Received: (qmail 39601 invoked by uid 500); 8 Nov 2019 11:36:03 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 39592 invoked by uid 99); 8 Nov 2019 11:36:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Nov 2019 11:36:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C4BCAC0849 for ; Fri, 8 Nov 2019 11:36:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -112.999 X-Spam-Level: X-Spam-Status: No, score=-112.999 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id A2wEa1AwaGQd for ; Fri, 8 Nov 2019 11:36:01 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=jira@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with SMTP id A02B0BC560 for ; Fri, 8 Nov 2019 11:36:01 +0000 (UTC) Received: (qmail 39588 invoked by uid 99); 8 Nov 2019 11:36:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Nov 2019 11:36:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 84CE6E1312 for ; Fri, 8 Nov 2019 11:36:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 03C39780472 for ; Fri, 8 Nov 2019 11:36:00 +0000 (UTC) Date: Fri, 8 Nov 2019 11:36:00 +0000 (UTC) From: "David de L. (Jira)" To: commits@airflow.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (AIRFLOW-5873) KubernetesPodOperator fixes and test MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 David de L. created AIRFLOW-5873: ------------------------------------ Summary: KubernetesPodOperator fixes and test Key: AIRFLOW-5873 URL: https://issues.apache.org/jira/browse/AIRFLOW-5873 Project: Apache Airflow Issue Type: Bug Components: operators Affects Versions: 1.10.6 Reporter: David de L. Assignee: David de L. Fix For: 1.10.7 * `KubernetesPodOperator` kwarg `resources` is erroneously passed to `base_= operator`, instead should only go to `PodGenerator`. The two have different= syntax. (both on `master` and `v1-10-test` branches) * `KubernetesPodOperator` kwarg `in_cluster` erroneously defaults to False= in comparison to `default_args.py` * `kubernetes/pod.py`: `Resources` does not have `__slots__` so accepts ar= bitrary values in `setattr` (present on=C2=A0`v1-10-test` branch [https://g= ithub.com/apache/airflow/blame/v1-10-test/airflow/contrib/operators/kuberne= tes_pod_operator.py#L166]) * `v1-10-test` is behind `master` with KubernetesPodOperator fixes and ref= actors ** e.g. move kubernetes folder one level up from `/contrib`=C2=A0[https://= github.com/apache/airflow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/ai= rflow/contrib/operators/kubernetes_pod_operator.py#L21] ** fix `xcom_push` to `do_xcom_push`=C2=A0[https://github.com/apache/airfl= ow/blame/4dd24a2c595d4042ffe745aed947eaaea6abb652/airflow/contrib/operators= /kubernetes_pod_operator.py#L90] -- This message was sent by Atlassian Jira (v8.3.4#803005)