From commits-return-74719-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Sun Nov 10 13:34:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 75456180661 for ; Sun, 10 Nov 2019 14:34:39 +0100 (CET) Received: (qmail 7806 invoked by uid 500); 10 Nov 2019 13:34:38 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 7794 invoked by uid 99); 10 Nov 2019 13:34:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Nov 2019 13:34:38 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] OmerJog commented on issue #6531: [AIRFLOW-5882] Add ti_dep for not being in the RUNNING state Message-ID: <157339287870.19187.9328416047057527897.gitbox@gitbox.apache.org> Date: Sun, 10 Nov 2019 13:34:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit OmerJog commented on issue #6531: [AIRFLOW-5882] Add ti_dep for not being in the RUNNING state URL: https://github.com/apache/airflow/pull/6531#issuecomment-552195333 @saguziel There are style errors: ``` airflow/ti_deps/deps/task_not_running_dep.py:1:0: C0111: Missing module docstring (missing-docstring) airflow/ti_deps/deps/task_not_running_dep.py:25:0: C0111: Missing class docstring (missing-docstring) airflow/ti_deps/deps/task_not_running_dep.py:36:15: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck) airflow/ti_deps/deps/task_not_running_dep.py:42:4: W0222: Signature differs from overridden '_get_dep_statuses' method (signature-differs) ************* Module airflow.utils.log.json_formatter airflow/utils/log/json_formatter.py:1:0: R0401: Cyclic import (airflow -> airflow.executors -> airflow.executors.kubernetes_executor -> airflow.kubernetes.pod_launcher) (cyclic-import) airflow/utils/log/json_formatter.py:1:0: R0401: Cyclic import (airflow.executors -> airflow.executors.kubernetes_executor -> airflow.kubernetes.pod_generator) (cyclic-import) airflow/utils/log/json_formatter.py:1:0: R0401: Cyclic import (airflow.executors -> airflow.executors.kubernetes_executor -> airflow.kubernetes.pod_launcher -> airflow.kubernetes.pod_generator) (cyclic-import) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services