From commits-return-73843-archive-asf-public=cust-asf.ponee.io@airflow.apache.org Mon Nov 4 16:23:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F19AE180658 for ; Mon, 4 Nov 2019 17:23:08 +0100 (CET) Received: (qmail 90177 invoked by uid 500); 4 Nov 2019 16:23:08 -0000 Mailing-List: contact commits-help@airflow.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@airflow.apache.org Delivered-To: mailing list commits@airflow.apache.org Received: (qmail 90168 invoked by uid 99); 4 Nov 2019 16:23:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Nov 2019 16:23:08 +0000 From: GitBox To: commits@airflow.apache.org Subject: [GitHub] [airflow] mik-laj commented on a change in pull request #6496: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing. Depends on [AIRFLOW-5827] [AIRFLOW-5830] [AIRFLOW-5829] Message-ID: <157288458824.8671.11724400261545898113.gitbox@gitbox.apache.org> Date: Mon, 04 Nov 2019 16:23:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mik-laj commented on a change in pull request #6496: [AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing. Depends on [AIRFLOW-5827] [AIRFLOW-5830] [AIRFLOW-5829] URL: https://github.com/apache/airflow/pull/6496#discussion_r342140291 ########## File path: breeze ########## @@ -458,35 +475,47 @@ do echo "Python version: ${PYTHON_VERSION}" echo shift 2 ;; - -E|--env) - export ENV="${2}"; - echo - echo "Environment: ${ENV}" - echo - shift 2 ;; -B|--backend) export BACKEND="${2}"; echo echo "Backend: ${BACKEND}" echo shift 2 ;; - -K|--kubernetes-version) - export KUBERNETES_VERSION="${2}"; + -K|--start-kubernetes-cluster) + export START_KUBERNETES_CLUSTER="true"; + export AIRFLOW_CONTAINER_FORCE_DOCKER_BUILD="true" echo - echo "Kubernetes version: ${KUBERNETES_VERSION}" + echo "Starting kubernetes cluster" echo - shift 2 ;; + shift ;; + -z|--recreate-kubernetes-cluster) + export RECREATE_KUBERNETES_CLUSTER="true"; + echo + echo "Recreate kubernetes cluster" + echo + shift ;; -M|--kubernetes-mode) export KUBERNETES_MODE="${2}"; echo echo "Kubernetes mode: ${KUBERNETES_MODE}" echo shift 2 ;; + -V|--kubernetes-version) + export KUBERNETES_VERSION="${2}"; + echo + echo "Kubernetes version: ${KUBERNETES_VERSION}" + echo + shift 2 ;; -s|--skip-mounting-local-sources) SKIP_MOUNTING_LOCAL_SOURCES="true" echo "Skip mounting local sources: ${SKIP_MOUNTING_LOCAL_SOURCES}" echo shift ;; + -N|--no-deps) + export AIRFLOW_CONTAINER_DEPS="false" + echo "Only run airflow-testing image without dependent images" Review comment: ```diff + echo echo "Only run airflow-testing image without dependent images" ``` For consistency. BTW. Do we need so many enterów? Maybe two at the beginning and end of the getop loop are enough ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services