airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5830) Get rid of slim image
Date Mon, 04 Nov 2019 09:02:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966484#comment-16966484
] 

ASF GitHub Bot commented on AIRFLOW-5830:
-----------------------------------------

potiuk commented on pull request #6494:  [AIRFLOW-5830] Get rid of slim image (depends on
[AIRFLOW-5826]  [AIRFLOW-5827])
URL: https://github.com/apache/airflow/pull/6494
 
 
   NOTE TO REVIEWER: This change depends on #6490 and #6493 so please review only last commit.
   
   The slim image gave only very small gain on executing the tests in CI. The
   image was significantly smaller, but then for local development and testing
   you needed both full CI and SLIM-CI image.
   
   This made the scripts and docker image needlessly complex - especially
   in the wake of coming Production image it turned to be premature
   optimisation really. While it sped-up (slightly - by 10-20 seconds) some
   static check jobs in Travis, it increased time needed by developers
   to have a working environment and to keep it updated every time it was
   needed (by minutes)
   
   Also having two separately managed images made it rather complex to join
   some of the Travis CI jobs (there is a follow-up change with getting rid
   of Checklicence image).
   
   With this change both static checks and tests are executed using single
   image. That also opens doors for further simplification of the scripts
   and easier implementation of production image.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5826
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Get rid of slim image
> ---------------------
>
>                 Key: AIRFLOW-5830
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5830
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.6
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> We can get rid of the slim image and use the ci image everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message