airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (AIRFLOW-5829) Get rid of checklicence image
Date Mon, 04 Nov 2019 09:08:00 GMT

    [ https://issues.apache.org/jira/browse/AIRFLOW-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966489#comment-16966489
] 

ASF GitHub Bot commented on AIRFLOW-5829:
-----------------------------------------

potiuk commented on pull request #6495: [AIRFLOW-5829] Get rid of the checklicence image.
Depends on [AIRFLOW-5826] [AIRFLOW-5827]  [AIRFLOW-5830])
URL: https://github.com/apache/airflow/pull/6495
 
 
   NOTE TO REVIEWER. This change depends on #6493 #6490  #6494 so please review only last
commit.
   
   This change is a further step of simplifying the set of scripts
   used by CI. The separate checklicence image was implemented as an
   optimisation of the licence check time. The image to download was
   small and could be downloaded slightly faster in CI. However that
   made all the management script more complex and lead to having
   separate jobs for check licence and static checks. That lead to
   actually longer time of Travis jobs - because new machine had to
   be spun-off for checklicence check only.
   
   With this change, the CI image is the only one left and it is slightly
   bigger (with RAT tool added) but the same image is used for all the
   tests - unit tests, static checks and checklicence checks.
   
   This also makes it easier to manage the images and decreases update
   overhead on the developers using Breeze.
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/)
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5829
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use
it.
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md)
so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Get rid of checklicence image
> -----------------------------
>
>                 Key: AIRFLOW-5829
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5829
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: ci
>    Affects Versions: 2.0.0, 1.10.5
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> We can get rid of checklicence image and run checklicence checks using the standard CI
image



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message