airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <>
Subject [jira] [Commented] (AIRFLOW-5520) DataflowPythonOperator dependency management requires side effects
Date Fri, 15 Nov 2019 16:00:14 GMT


ASF GitHub Bot commented on AIRFLOW-5520:

mik-laj commented on pull request #6590: [AIRFLOW-5520] Add options to run Dataflow in a virtual
   Make sure you have checked _all_ steps below.
   ### Jira
   - [ ] My PR addresses the following [Airflow Jira](
issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - In case you are fixing a typo in the documentation you can prepend your commit with
\[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow
Improvement Proposal ([AIP](
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd
Party License Policy](
   ### Description
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely
good reason:
   ### Commits
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed
multiple commits if they address the same issue. In addition, my commits follow the guidelines
from "[How to write a good git commit message](":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   ### Documentation
   - [ ] In case of new functionality, my PR adds documentation that describes how to use
     - All the public functions and the classes in the PR contain docstrings that explain
what it does
     - If you implement backwards incompatible changes, please leave a note in the [](
so we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> DataflowPythonOperator dependency management requires side effects
> ------------------------------------------------------------------
>                 Key: AIRFLOW-5520
>                 URL:
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: gcp
>    Affects Versions: 1.10.2
>            Reporter: Jacob Ferriero
>            Priority: Major
> When using DataflowPythonOperator it is difficult to manage apache beam version, (and
other python dependencies) without affecting your entire airflow environment. It seems the
Dataflow hook just submits a subprocess and python 
> The operator / hook should be improved to isolate python dependencies for running run
> Perhaps this could be achieved in a virtual environment (similar to PythonVirtualEnvOperator).
> For beam it's often customary to specify a --requirements_file or --setup_file to manage
python dependencies, we could run one of these in the venv to get it setup. 

This message was sent by Atlassian Jira

View raw message