airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports
Date Sat, 30 Nov 2019 19:29:44 GMT
ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to
avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r352300164
 
 

 ##########
 File path: docs/plugins.rst
 ##########
 @@ -167,7 +167,7 @@ definitions in Airflow.
     from airflow.models.baseoperator import BaseOperatorLink
     from airflow.operators.gcs_to_s3 import GoogleCloudStorageToS3Operator
     from airflow.sensors.base_sensor_operator import BaseSensorOperator
-    from airflow.executors.base_executor import BaseExecutor
+    from airflow.executors.base_executors import BaseExecutor
 
 Review comment:
   This counds as a breaking change - someone has probably created a custom Executor out there.
Is it possible not not change this module name please?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message