airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] nuclearpinguin commented on a change in pull request #6692: [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible
Date Sat, 30 Nov 2019 14:04:14 GMT
nuclearpinguin commented on a change in pull request #6692: [AIRFLOW-6130] Make Cassandra to
GCS operator pylint compatible
URL: https://github.com/apache/airflow/pull/6692#discussion_r352286968
 
 

 ##########
 File path: airflow/operators/cassandra_to_gcs.py
 ##########
 @@ -209,29 +201,38 @@ def _write_local_schema_file(self, cursor):
         schema = []
         tmp_schema_file_handle = NamedTemporaryFile(delete=True)
 
-        for name, type in zip(cursor.column_names, cursor.column_types):
-            schema.append(self.generate_schema_dict(name, type))
+        for name, type_ in zip(cursor.column_names, cursor.column_types):
+            schema.append(self.generate_schema_dict(name, type_))
         json_serialized_schema = json.dumps(schema).encode('utf-8')
 
         tmp_schema_file_handle.write(json_serialized_schema)
         return {self.schema_filename: tmp_schema_file_handle}
 
-    def _upload_to_gcs(self, files_to_upload):
+    def _upload_to_gcs(self, files_to_upload: Dict):
 
 Review comment:
   Are you sure about that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message