airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] nuclearpinguin commented on a change in pull request #6472: [AIRFLOW-6058] Running tests with pytest
Date Wed, 27 Nov 2019 14:56:43 GMT
nuclearpinguin commented on a change in pull request #6472: [AIRFLOW-6058] Running tests with
pytest
URL: https://github.com/apache/airflow/pull/6472#discussion_r351264415
 
 

 ##########
 File path: tests/task/task_runner/test_standard_task_runner.py
 ##########
 @@ -121,11 +121,16 @@ def test_on_kill(self):
         runner = StandardTaskRunner(job1)
         runner.start()
 
-        # give the task some time to startup
-        time.sleep(3)
-
+        # Give the task some time to startup
+        time.sleep(10)
 
 Review comment:
   This test is flaky, but now with the loop below I think we can go back to 3s.
   Edit: and it seems that 10s is better as the test does not fail

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message