airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports. Depends on [AIRFLOW-6010]
Date Mon, 25 Nov 2019 23:36:27 GMT
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class
to avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#discussion_r350477875
 
 

 ##########
 File path: airflow/executors/local_executor.py
 ##########
 @@ -128,28 +133,30 @@ def run(self):
 
 class LocalExecutor(BaseExecutor):
     """
-    LocalExecutor executes tasks locally in parallel. It uses the
-    multiprocessing Python library and queues to parallelize the execution
+    LocalExecutor executes tasks locally in parallel.
+
+    It uses the multiprocessing Python library and queues to parallelize the execution
     of tasks.
     """
     def __init__(self, parallelism: int = PARALLELISM):
         super().__init__(parallelism=parallelism)
         self.manager: Optional[SyncManager] = None
-        self.result_queue: Optional['MultiprocessingQueue[Tuple[ExecutorKeyType, str]]']
= None
+        self.result_queue: Optional['MultiprocessingQueue[TaskInstanceState]'] = None
         self.workers: List[QueuedLocalWorker] = []
         self.workers_used: int = 0
         self.workers_active: int = 0
         self.impl: Optional[Union['LocalExecutor.UnlimitedParallelism',
                                   'LocalExecutor.LimitedParallelism']] = None
 
     class UnlimitedParallelism:
-        """Implements LocalExecutor with unlimited parallelism, starting one process
-        per each command to execute."""
+        """
+        Implements LocalExecutor with unlimited parallelism, starting one process
+        per each command to execute.
+        """
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message