airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports. Depends on [AIRFLOW-6010]
Date Mon, 25 Nov 2019 22:58:20 GMT
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class
to avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#discussion_r350466698
 
 

 ##########
 File path: airflow/executors/base_executor.py
 ##########
 @@ -202,11 +216,15 @@ def get_event_buffer(self, dag_ids=None):
         return cleared_events
 
     def execute_async(self,
-                      key: ExecutorKeyType,
+                      key: TaskInstanceKey,
                       command_to_run: CommandType,
                       executor_config: Any = None):  # pragma: no cover
         """
         This method will execute the command asynchronously.
+
+        :param key: Unique key for the task instance
+        :param command_to_run: Command to run
 
 Review comment:
   Yep. It was more of an experiment :).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message