airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] feluelle commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports. Depends on [AIRFLOW-6010]
Date Mon, 25 Nov 2019 15:38:45 GMT
feluelle commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class
to avoid cyclic imports. Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#discussion_r350257531
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -1015,7 +1016,7 @@ def _change_state_for_executable_task_instances(self, task_instances,
         :type task_instances: list[airflow.models.TaskInstance]
         :param acceptable_states: Filters the TaskInstances updated to be in these states
         :type acceptable_states: Iterable[State]
-        :rtype: list[airflow.utils.dag_processing.SimpleTaskInstance]
+        :rtype: list[airflow.executors.executor_types.SimpleTaskInstance]
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message