airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports. Depends on [AIRFLOW-6010]
Date Mon, 25 Nov 2019 06:38:53 GMT
potiuk commented on issue #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports.
Depends on [AIRFLOW-6010]
URL: https://github.com/apache/airflow/pull/6596#issuecomment-558013576
 
 
   Hey @ashb @kaxil @bolkedebruin @mik-laj -> can you please take a look at this one and
see if you can start reviewing it. It fixes the seemingly random "cyclic dependencies" found
by pylint. I am fixing the last failing tests, but I think it's worth taking a look even now.

   
   I not only fixed the cyclic dependencies - by moving executor-related classes - but I also
made the whole `executors` class pylint and mypy compatible. I added all type annotations
and happily used variable annotations from python 3.6 which made the executor's code actually
... understandable :). Executors used a lot of tuples to communicate between different objects
and I managed to reconstruct the actual types used, I made "aliases" of those types and let
mypy + pylint actually verify that they are used properly. Along the way I found that one
of the "queues" in execute_async could be removed as it was not used. 
   
   Pls. take a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message