airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables
Date Wed, 20 Nov 2019 16:02:06 GMT
potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and
pylint disables
URL: https://github.com/apache/airflow/pull/6601#discussion_r348568088
 
 

 ##########
 File path: airflow/contrib/operators/dynamodb_to_s3.py
 ##########
 @@ -32,7 +32,7 @@
 from boto.compat import json  # type: ignore
 
 from airflow.contrib.hooks.aws_dynamodb_hook import AwsDynamoDBHook
-from airflow.models.baseoperator import BaseOperator
+from airflow.models import BaseOperator
 
 Review comment:
   I think they are for operators. The change for DAG is coming as follow-up. Have you seen
some place where we use it inconsistently ? I think my pre-commit hooks applies the same checks
for "operators" and "contrib" and "providers".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message