airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class to avoid cyclic imports
Date Mon, 18 Nov 2019 13:40:36 GMT
potiuk commented on a change in pull request #6596: [AIRFLOW-6004] Untangle Executors class
to avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r347385003
 
 

 ##########
 File path: airflow/executors/dask_executor.py
 ##########
 @@ -44,6 +42,7 @@ def __init__(self, cluster_address=None):
         super().__init__(parallelism=0)
 
     def start(self):
+        import distributed
 
 Review comment:
   (I am talking here about removing import LocalExecutor/import SequentialExecutor in the
__init__. This was really bad pattern. I will bring the "AvailableExecutors" class back to
__init__ however.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message