airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy load CLI commands
Date Mon, 18 Nov 2019 10:13:26 GMT
ashb commented on a change in pull request #6594: [AIRFLOW-6001][depends on AIRFLOW-6000] Lazy
load CLI commands
URL: https://github.com/apache/airflow/pull/6594#discussion_r347294288
 
 

 ##########
 File path: tests/cli/commands/test_variable_command.py
 ##########
 @@ -0,0 +1,132 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+import os
+import unittest
+
+from airflow import models
+from airflow.bin import cli
+from airflow.cli.commands import variable_command
+from airflow.models import Variable
+
+DEV_NULL = "/dev/null"
 
 Review comment:
   
   ```suggestion
   DEV_NULL = os.devnull
   ```
   
   (or just us that value directly in the tests)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message