airflow-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [airflow] potiuk commented on issue #6595: [AIRFLOW-6002] Drop support for python 3.5
Date Sun, 17 Nov 2019 23:04:19 GMT
potiuk commented on issue #6595: [AIRFLOW-6002] Drop support for python 3.5
URL: https://github.com/apache/airflow/pull/6595#issuecomment-554798105
 
 
   > > There is one more python 3.5 in breeze-complete
   > 
   > Why were those harcoded everywhere @potiuk ?
   
   Sorry for that. That was unfortunate indeed. 
   
   I have a refactor (WIP) for the whole set of bash scripts to make them way simpler (#6500)
- currently we are at 8/12 PRs (https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-5606)
done for the production image change that simplified the scripts (and I will make a DEFAULT_PYTHON_VERSION
there in common utils script that we will use).
   
   Unfortunately this is not always super-easy for the bash scripts - especially that so far
we had a separate build script for Dockerhub (hooks/build) - this is where the whole build
logic was implemented. We called this script from within other scripts (and separately in
Dockerhub), and it got far too complex.
   
   I reverted the logic in (#6500) so that we have common utils used everywhere and then it
will be possible to make it defined in one place and have one constant for it (in bash scripts).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message